Maor Lipchuk has posted comments on this change. Change subject: core: OVFs that aren't stored on any domain should be stored on all ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34292/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java: Line 210: List<Guid> ids = Line 211: dao.getVmAndTemplatesIdsWithoutAttachedImageDisks(false, false); Line 212: assertTrue(ids.contains(FixturesTool.VM_WITHOUT_DISKS)); Line 213: assertTrue(ids.contains(FixturesTool.VM_TEMPLATE_WITHOUT_DISKS)); Line 214: assertFalse(ids.contains(FixturesTool.VM_TEMPLATE_RHEL5)); Perhaps you should also add tests for shareable and snapshot disks Line 215: } Line 216: Line 217: @Test Line 218: public void testGetAllNamesPinnedToHostReturnsNothingForRandomHost() throws Exception { -- To view, visit http://gerrit.ovirt.org/34292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeecc6c4526800656315842384d83830fdf0b72b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
