mooli tayer has posted comments on this change.

Change subject: notifier: modify the oid schema for SNMP notification.
......................................................................


Patch Set 12:

(2 comments)

Rebased on top of snmp patches, hoping to finally push this
Which has been stuck for now good reason.

http://gerrit.ovirt.org/#/c/32951/12/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java:

Line 2: 
Line 3: import java.io.IOException;
Line 4: import java.net.InetAddress;
Line 5: import java.text.SimpleDateFormat;
Line 6:     import java.util.HashMap;
bahh
Line 7: import java.util.LinkedList;
Line 8: import java.util.List;
Line 9: import java.util.Map;
Line 10: import java.util.regex.Matcher;


Line 136:         Target target = createTarget(profile);
Line 137:         for (Host host : profile.hosts) {
Line 138:             try {
Line 139:                 log.info("Generate an snmp trap for event: {} to 
address: {} ",
Line 140:                          event, host.name);
bahh
Line 141:                 target.setAddress(
Line 142:                     new UdpAddress(
Line 143:                         InetAddress.getByName(host.name),
Line 144:                         host.port


-- 
To view, visit http://gerrit.ovirt.org/32951
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to