Roy Golan has posted comments on this change. Change subject: core: OsInfo-related changes ......................................................................
Patch Set 23: (1 comment) looks good but waiting for the next patcheset http://gerrit.ovirt.org/#/c/30838/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java: Line 179: return vm.getGraphicsInfos().keySet(); Line 180: } else { Line 181: List<VmDevice> graphicDevices = Line 182: DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmIdAndType(vm.getId(), VmDeviceGeneralType.GRAPHICS); Line 183: > It's pretty neat collection, but I'm not sure how it helps here. I'm transf here it is just more compact then regular set but you're right there is no real added value here. Line 184: Set<GraphicsType> graphicsTypes = new HashSet<>(); Line 185: Line 186: for (VmDevice graphicDevice : graphicDevices) { Line 187: GraphicsType type = GraphicsType.fromString(graphicDevice.getDevice()); -- To view, visit http://gerrit.ovirt.org/30838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c7126308ab4e5e5418d804a8550a50e9994894 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
