Ori Liel has posted comments on this change.
Change subject: restapi: implement mandatory/optional header def in RSDL
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
Trivial comments, after them - approved
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2533: </xs:attribute>
whitespace
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Request.java
Line 33: public void addUrl_params(String name, ParamData value) {
there shouldn't be an underscore in the method name, against java conventions
--
To view, visit http://gerrit.ovirt.org/6823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ba91f2faf11e51ea8e8954ff5c6fb74e6cf4e8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
