Omer Frenkel has posted comments on this change. Change subject: core: Graphics Device CRUD ......................................................................
Patch Set 15: Code-Review+1 (1 comment) looks ok, minor comment http://gerrit.ovirt.org/#/c/25409/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsDeviceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsDeviceCommand.java: Line 18: Line 19: @Override Line 20: protected boolean canDoAction() { Line 21: GraphicsDevice dev = getParameters().getDev(); Line 22: return dev.getDeviceId() != null && dev.getVmId() != null; its not nice to fail without a reason, you should add something to the canDoActionMessages Line 23: } -- To view, visit http://gerrit.ovirt.org/25409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9eed1ddb4aa8e8376ba5eff662f1bdf49fda800 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
