Alon Bar-Lev has posted comments on this change. Change subject: core: Added the table vds_deloy_config ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/27028/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-04-28 16:22:09 +0530 Line 4: Commit: Shubhendu Tripathi <shtri...@redhat.com> Line 5: CommitDate: 2014-07-14 13:57:08 +0530 Line 6: Line 7: core: Added the table vds_deloy_config > deloy=>deploy Done Line 8: Line 9: Added the table to store the deploy configuration details which Line 10: could be used during host deploy. Line 11: http://gerrit.ovirt.org/#/c/27028/9/packaging/dbscripts/inst_sp.sql File packaging/dbscripts/inst_sp.sql: Line 82: -- Adds the vds deploy configuration if it does not exist already else updates the existing one Line 83: Create or replace FUNCTION inst_add_update_vds_deploy_config(v_cfg_name VARCHAR(50), v_cfg_type VARCHAR(30), v_cfg_value VARCHAR(50), INOUT v_cfg_id INTEGER) RETURNS SETOF INTEGER Line 84: AS $procedure$ Line 85: BEGIN Line 86: LOCK TABLE vds_deploy_config IN SHARE ROW EXCLUSIVE MODE; > why do you need this lock ??? removed. Line 87: if exists (select 1 from vds_deploy_config where cfg_name=v_cfg_name) then Line 88: update vds_deploy_config set cfg_type=v_cfg_type, cfg_value=v_cfg_value where cfg_name=v_cfg_name; Line 89: else Line 90: insert into vds_deploy_config(cfg_name, cfg_type, cfg_value) values(v_cfg_name, v_cfg_type, v_cfg_value); http://gerrit.ovirt.org/#/c/27028/9/packaging/dbscripts/upgrade/03_05_0760_create_vds_deploy_config_table.sql File packaging/dbscripts/upgrade/03_05_0760_create_vds_deploy_config_table.sql: > script should be prefixed with 03_06 upstream modified. Line 1: -- create vds_deploy_config table Line 2: CREATE SEQUENCE vds_deploy_config_seq INCREMENT BY 1 START WITH 1; Line 3: CREATE TABLE vds_deploy_config Line 4: ( -- To view, visit http://gerrit.ovirt.org/27028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
