Martin Mucha has uploaded a new change for review. Change subject: core: added engine-config values related to engine NICs health checking ......................................................................
core: added engine-config values related to engine NICs health checking Added three config values: EngineNics EngineNicsHealthCheckDelay EngineNicsHaveToBeUpAtLeast to set respective nics to be checked, delay between individual checks and time period in which all given nics must be always up (at each check) to pronounce system as healthy. Change-Id: Ief887e48b7a580dd3a6cdada01b597259c53313f Bug-Url: https://bugzilla.redhat.com/1117943 Signed-off-by: Martin Mucha <mmu...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/34220/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java index 7155d89..c31f909 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java @@ -9,6 +9,22 @@ import org.ovirt.engine.core.common.businessentities.SerialNumberPolicy; public enum ConfigValues { + + @Reloadable + @TypeConverterAttribute(String.class) + @DefaultValueAttribute("") + EngineNics, + + @Reloadable + @TypeConverterAttribute(Integer.class) + @DefaultValueAttribute("5000") //5000ms + EngineNicsHealthCheckDelay, + + @Reloadable + @TypeConverterAttribute(Integer.class) + @DefaultValueAttribute("300000") //1000*60*5ms ~ 5 minutes + EngineNicsHaveToBeUpAtLeast, + @Reloadable @TypeConverterAttribute(String.class) @DefaultValueAttribute("9b9002d1-ec33-4083-8a7b-31f6b8931648") diff --git a/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql b/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql index 6195759..f39b57d 100644 --- a/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql +++ b/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql @@ -829,6 +829,9 @@ select fn_db_add_config_value('SupportNUMAMigration','false','general'); +select fn_db_add_config_value('EngineNics','','general'); +select fn_db_add_config_value('EngineNicsHealthCheckDelay','5000','general'); +select fn_db_add_config_value('EngineNicsHaveToBeUpAtLeast','300000','general'); ------------------------------------------------------------------------------------ -- Update with override section ------------------------------------------------------------------------------------ diff --git a/packaging/etc/engine-config/engine-config.properties b/packaging/etc/engine-config/engine-config.properties index eea6ce6..ecef7b6 100644 --- a/packaging/etc/engine-config/engine-config.properties +++ b/packaging/etc/engine-config/engine-config.properties @@ -37,6 +37,12 @@ EnableVdsLoadBalancing.validValues=true,false EncryptHostCommunication.description="Determine whether to use secure communication with hosts" EncryptHostCommunication.type=Boolean +EngineNics.description="NICs to be regularly checked, whether their status is 'up'" +EngineNics.type=StringMultiple +EngineNicsHealthCheckDelay.description="Specifies delay between each engine NICs status check" +EngineNicsHealthCheckDelay.type=Integer +EngineNicsHaveToBeUpAtLeast.description="Specifies time interval in which all specified engine NICs must be up, otherwise engine NICs are considered as unhealthy, and certain operations will be blocked" +EngineNicsHaveToBeUpAtLeast.type=Integer FreeSpaceCriticalLowInGB.description="Critical low disk space alert threshold (in GB)" FreeSpaceCriticalLowInGB.type=Integer FreeSpaceCriticalLowInGB.validValues=0..2147483647 -- To view, visit http://gerrit.ovirt.org/34220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ief887e48b7a580dd3a6cdada01b597259c53313f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
