Juan Hernandez has posted comments on this change. Change subject: core, restapi,engine: Avoid enabling balloon device on VM edit ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Looks good. You will need a backend reviewer in order to merge. http://gerrit.ovirt.org/#/c/34208/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java: Line 1034: Line 1035: private static boolean isBalloonEnabled(VmManagementParametersBase params) { Line 1036: Boolean balloonEnabled = params.isBalloonEnabled(); Line 1037: return balloonEnabled != null ? balloonEnabled : Line 1038: VmDeviceUtils.isBalloonEnabled(params.getVmStaticData().getId()); As you are calling a method in the same class you may want to drop the "VmDeviceUtils." prefix. Line 1039: } Line 1040: Line 1041: public static boolean isVirtioScsiControllerAttached(Guid vmId) { Line 1042: return !getVirtioScsiControllers(vmId).isEmpty(); -- To view, visit http://gerrit.ovirt.org/34208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
