Greg Sheremeta has posted comments on this change. Change subject: webadmin: use new element-id-capable SortedColumn for vm statustext ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34210/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java: Line 38: sb.appendHtmlConstant("<div id=\""); //$NON-NLS-1$ Line 39: sb.appendEscaped(ElementIdUtils.createTableCellElementId(getElementIdPrefix(), getColumnId(), context)); Line 40: sb.appendHtmlConstant("\">"); //$NON-NLS-1$ Line 41: Line 42: // TODO use my element id and column index This is a stray TODO. I will remove. Line 43: for (HasCell<VM, ?> hasCell : hasCells) { Line 44: render(context, value, sb, hasCell); Line 45: } Line 46: -- To view, visit http://gerrit.ovirt.org/34210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97bb0a04d46e94efede5f46af35ebcee01a9dd70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
