Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 21: (3 comments) http://gerrit.ovirt.org/#/c/33458/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 69 Line 70 Line 71 Line 72 Line 73 are we still using this? I do not think we should. Line 61: List<? extends Certificate> result = null; Line 62: if (url.getProtocol().equalsIgnoreCase(String.valueOf("https"))) { Line 63: HttpURLConnection conn = null; Line 64: try { Line 65: conn = new HttpURLConnectionBuilder(url).setVerifyChain(false).create(); can you please use my new class? Line 66: result = Arrays.asList(((HttpsURLConnection) conn).getServerCertificates()); Line 67: } catch (CertificateException | NoSuchAlgorithmException | InvalidKeyException | NoSuchProviderException Line 68: | SignatureException | SSLHandshakeException ex) { Line 69: } catch (IOException | GeneralSecurityException e) { Line 97: try { Line 98: builder = new HttpURLConnectionBuilder().appendRelativePath(hostUrl, relativePath) Line 99: .setTrustStore(Paths.get( Line 100: EngineLocalConfig.getInstance().getVarDir().getAbsolutePath(), Line 101: "external_truststore") we need a separate variable for this Line 102: .toString()); Line 103: result = builder.create(); Line 104: handleCredentials(result); Line 105: } catch (Exception ex) { -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
