Vitor de Lima has uploaded a new change for review.

Change subject: core, restapi,engine: Avoid enabling balloon device on VM edit
......................................................................

core, restapi,engine: Avoid enabling balloon device on VM edit

Avoids the creation of a balloon device on every REST API call that
changes any of attibute of a VM.

Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152991
Signed-off-by: Vitor de Lima <vdel...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/34209/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
index 6e2c1ab..27822e1 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
@@ -1034,8 +1034,7 @@
     private static boolean isBalloonEnabled(VmManagementParametersBase params) 
{
         Boolean balloonEnabled = params.isBalloonEnabled();
         return balloonEnabled != null ? balloonEnabled :
-            osRepository.isBalloonEnabled(params.getVmStaticData().getOsId(),
-                    
ClusterUtils.getCompatibilityVersion(params.getVmStaticData()));
+            VmDeviceUtils.isBalloonEnabled(params.getVmStaticData().getId());
     }
 
     public static boolean isVirtioScsiControllerAttached(Guid vmId) {


-- 
To view, visit http://gerrit.ovirt.org/34209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vitor de Lima <vdel...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to