anmolbabu has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/33845/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-06 17:19:58 +0530 Line 4: Commit: Anmol Babu <anb...@redhat.com> Line 5: CommitDate: 2014-10-08 12:17:53 +0530 Line 6: Line 7: engine : Query to fetch list of volumes eligible for geo-rep > %s/geo-rep/geo replication/g Done Line 8: Line 9: Query to fetch list of volumes eligible for geo-rep session. Line 10: This query fetches a list of volumes satisfying the required Line 11: conditions for geo-rep session establishment. Line 5: CommitDate: 2014-10-08 12:17:53 +0530 Line 6: Line 7: engine : Query to fetch list of volumes eligible for geo-rep Line 8: Line 9: Query to fetch list of volumes eligible for geo-rep session. > %s/for geo-rep session/for geo replication/g Done Line 10: This query fetches a list of volumes satisfying the required Line 11: conditions for geo-rep session establishment. Line 12: Line 13: Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 http://gerrit.ovirt.org/#/c/33845/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionCreateEligibleVolumeListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionCreateEligibleVolumeListQuery.java: Line 9: import org.ovirt.engine.core.common.queries.gluster.GlusterVolumeQueriesParameters; Line 10: import org.ovirt.engine.core.compat.Guid; Line 11: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 12: Line 13: public class GetGeoRepSessionCreateEligibleVolumeListQuery<P extends GlusterVolumeQueriesParameters> extends GlusterQueriesCommandBase<P> { > How about name GetEligibleVolumesForGeoRepEnablingQuery??? Done Line 14: Line 15: public GetGeoRepSessionCreateEligibleVolumeListQuery(P parameters) { Line 16: super(parameters); Line 17: } -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches