Allon Mureinik has posted comments on this change.
Change subject: core: HibernateVmCommand- simplified canDoAction() method
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 239: if (getStorageDomainId().equals(Guid.Empty)) {
Guid.Empty.equals(...) - avoid annoying null issues.
Line 249: if (getVm().getstatus() != VMStatus.Up) {
consider doing this in an else-if, or perhaps a switch-case structure
Line 256: if (AsyncTaskManager.getInstance().EntityHasTasks(getVmId()))
{
don't we have a sensible accesor for this?
Line 264:
DbFacade.getInstance().getSnapshotDao().exists(getVmId(),
SnapshotType.STATELESS)) {
use getSnaphosDao() [possibly in an additional patch]
Line 269: if
(DbFacade.getInstance().getVmPoolDAO().getVmPoolMapByVmGuid(getVmId()) != null)
{
Use getVmPoolDAO() [possibly in an additional patch]
Line 276:
DbFacade.getInstance().getStorageDomainDAO().get(getStorageDomainId().getValue());
Use getStorageDomainDAO() [possibly in an additional patch]
--
To view, visit http://gerrit.ovirt.org/6804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69135ed771919d3e5a398fa340bd741c63b90f0c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
