Daniel Erez has posted comments on this change. Change subject: webadmin: preview partial snapshot confirmation dialog ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33869/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java: Line 90: public void edit(final SnapshotModel model) { Line 91: driver.edit(model); Line 92: Line 93: if (model.isShowMemorySnapshotWarning() && !model.isShowPartialSnapshotWarning()) { Line 94: Style dialogStyle = getParent().getParent().getParent().getElement().getStyle(); > Hideous, not to mention that if we change something in the infrastructure t Indeed an ugly workaround :) Tried to find an alternative using DOM manipulation but the widget isn't attached to the document at this point, so it's actually safe enough as is... Line 95: dialogStyle.setWidth(450, Style.Unit.PX); Line 96: dialogStyle.setHeight(200, Style.Unit.PX); Line 97: } Line 98: -- To view, visit http://gerrit.ovirt.org/33869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabd59025d7c7b96ae92898efe34e20985d2e9750 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
