Yair Zaslavsky has uploaded a new change for review.

Change subject: aaa: Change the check of internal command execution
......................................................................

aaa: Change the check of internal command execution

Bug-Url: https://bugzilla.redhat.com/1121954

Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/34155/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
index 5915bc9..397f041 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
@@ -212,7 +212,7 @@
         if (dbUser.getDomain() != null && dbUser.getExternalId() != null) {
             AddUserParameters parameters = new AddUserParameters(dbUser);
             VdcReturnValueBase result = 
runInternalAction(VdcActionType.AddUser, parameters, 
cloneContextAndDetachFromParent());
-            if (result.getCanDoAction()) {
+            if (result.getSucceeded()) {
                 Guid id = (Guid) result.getActionReturnValue();
                 if (id != null) {
                     return getDbUserDAO().get(id);
@@ -229,7 +229,7 @@
         if (groupToAdd.getDomain() != null && groupToAdd.getExternalId() != 
null) {
             AddGroupParameters parameters = new AddGroupParameters(groupToAdd);
             VdcReturnValueBase result = 
runInternalAction(VdcActionType.AddGroup, parameters, 
cloneContextAndDetachFromParent());
-            if (result.getCanDoAction()) {
+            if (result.getSucceeded()) {
                 Guid id = (Guid) result.getActionReturnValue();
                 if (id != null) {
                     return getAdGroupDAO().get(id);


-- 
To view, visit http://gerrit.ovirt.org/34155
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to