Yair Zaslavsky has posted comments on this change. Change subject: core: use previous disk operator on template version update ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34150/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java: Line 12: private static final long serialVersionUID = 8641610721114989096L; Line 13: Line 14: private ArrayList<DiskImage> diskInfoList; Line 15: private TemplateProvisioningMethod templateProvisioningMethod = TemplateProvisioningMethod.THIN; Line 16: /** The ID of the user in the directory service which should serve as disk-operator */ change comment. Line 17: private Guid diskOperatorUserId; Line 18: Line 19: public AddVmParameters() { Line 20: } Line 13: Line 14: private ArrayList<DiskImage> diskInfoList; Line 15: private TemplateProvisioningMethod templateProvisioningMethod = TemplateProvisioningMethod.THIN; Line 16: /** The ID of the user in the directory service which should serve as disk-operator */ Line 17: private Guid diskOperatorUserId; consider diskOperatorDirectoryEntryId or diskOperatorAuthzElementId. Authz is perfectly fine, the fact most of the developers do not know it, does not mean it's not a valid term :) But anyway, please also add "db" before the id - I know, this is guid, but still - every user and group have two ideas - engine id (the db id) and the id in the external provider (a string). Line 18: Line 19: public AddVmParameters() { Line 20: } Line 21: -- To view, visit http://gerrit.ovirt.org/34150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd9604c7a219e49d140576a66c9b15e9abb34d79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
