Eldan Shachar has posted comments on this change. Change subject: restapi: show host-id for a vm in an unknown state ......................................................................
Patch Set 1: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/34146/1/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java: Line 497: model.getDisplay().setPort(displayPort==null || displayPort==-1 ? null : displayPort); Line 498: Integer displaySecurePort = entity.getDisplaySecurePort(); Line 499: model.getDisplay().setSecurePort(displaySecurePort==null || displaySecurePort==-1 ? null : displaySecurePort); Line 500: model.getDisplay().setMonitors(entity.getNumOfMonitors()); Line 501: model.getDisplay().setSingleQxlPci(entity.getSingleQxlPci()); 'Boot sequence' and 'Display type' are filled using: static data when VM is down, or by dynamic data when VM is running(in order to handle run once). This means that after this patch, if a vm is in an unknown state and its dynamic data wasn't filled, these two fields will be incorrect because they will be based on dynamic data. in 3.6 it was solved using 'showDynamicInfo' parameter and it was moved to a separate condition. Line 502: } else { Line 503: if (model.getOs() != null) { Line 504: for (Boot boot : map(entity.getDefaultBootSequence(), null)) { Line 505: model.getOs().getBoot().add(boot); -- To view, visit http://gerrit.ovirt.org/34146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8010522e42d1a7cfc963b2408b22c3bc468e30eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
