Shireesh Anjal has posted comments on this change. Change subject: restapi: removing access protocols and acl in create volume ......................................................................
Patch Set 1: Using only the strongly-typed way, will mean that REST api will not support configuring these through volume options, which will look very wrong and inconsistent. We must support setting any volume option through REST api which is supported by the GlusterFS CLI, and consequently the webadmin GUI. There are 40+ volume options, and many of them have a restricted set of valid values. If we want to use strong typing for all of them, we'll probably have to introduce volume level fields for all of them, and keep changing the volume entity whenever new volume options are added. This doesn't sound like a scalable model. I agree that this breaks the api, but since we know that no one is using it today, it is safe to make this change, rather than carry this baggage in future. -- To view, visit http://gerrit.ovirt.org/6410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0dad83cc2e3dc0dfb698677084150d870289eff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
