Moti Asayag has posted comments on this change. Change subject: engine: Introduce HostNetworkInterfacesPersister ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/34070/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java: Line 91: N > pls s/update/override/g Done Line 115: updateNicsWithUserConfiguration(reportedNic, userConfiguredNicsByName); Line 116: } Line 117: Line 118: /** Line 119: * preserves certain nic attributes > "certain" - pls be more specific (engine managed) Done Line 120: * Line 121: * @param sourceNic Line 122: * the nic which its attributes should be preserved Line 123: * @param targetNic Line 122: * the nic which its attributes should be preserved Line 123: * @param targetNic Line 124: * the nic which will be updated according to the source nic properties Line 125: */ Line 126: private void preserveNicAttributes(VdsNetworkInterface sourceNic, VdsNetworkInterface targetNic) { > see javadoc comment Done Line 127: targetNic.setLabels(sourceNic.getLabels()); Line 128: targetNic.setQosOverridden(sourceNic.isQosOverridden()); Line 129: targetNic.setCustomProperties(sourceNic.getCustomProperties()); Line 130: } http://gerrit.ovirt.org/#/c/34070/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java: Line 221: List<VdsNetworkInterface> dbNics, Line 222: Map<String, VdsNetworkInterface> modifiedNicsByName) { Line 223: Map<String, VdsNetworkInterface> reportedNicsByNames = Entities.entitiesByName(reportedNics); Line 224: Line 225: HostNetworkInterfacesPersisterImpl persister = new HostNetworkInterfacesPersisterImpl(DbFacade.getInstance()); > pls move that to ctor Done Line 226: persister.removeUnreportedInterfaces(reportedNicsByNames, dbNics); Line 227: List<VdsNetworkInterface> nicsForUpdate = Line 228: persister.updateModifiedInterfaces(reportedNicsByNames, dbNics, modifiedNicsByName); Line 229: persister.createNewInterfaces(reportedNics, nicsForUpdate, modifiedNicsByName); -- To view, visit http://gerrit.ovirt.org/34070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0701a302781a9fa147c65818764bddf8429828 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
