Vojtech Szocs has posted comments on this change. Change subject: restapi,userportal,webadmin: reformat web.xml ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/33983/2/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml: Line 5: with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Line 6: Unless required by applicable law or agreed to in writing, software distributed Line 7: under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES Line 8: OR CONDITIONS OF ANY KIND, either express or implied. See the License for Line 9: the specific language governing permissions and limitations under the License. --> Is re-formatting license info legal? :-) I'd advise to keep original license info comment un-formatted. Line 10: Line 11: <web-app xmlns="http://java.sun.com/xml/ns/javaee"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; Line 12: xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd"; Line 13: version="3.0"> -- To view, visit http://gerrit.ovirt.org/33983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2233a4cb959c87fe0ad13a98ecf5d38d4c6a2184 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
