Arik Hadas has posted comments on this change. Change subject: frontend: do not use AddVmFromScratch ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/33142/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 2130: { Line 2131: return; Line 2132: } Line 2133: Line 2134: if (model.getProvisioning().getEntity()) > is this reliable? is the !model.getProvisioning().getEntity() guaranteed to this is intentional - it doesn't matter which template we use, blank template or other template, when we determine whether AddVm or AddVmFromTemplate should be invoked. it should be based only on the disks provisioning - either it is thin (AddVm) or clone (AddVmFromTemplate). since blank template doesn't have disks, it doesn't really matter so we can use both of them (but still, for the general case we look at the disks provisioning) Line 2135: { Line 2136: model.startProgress(null); Line 2137: Line 2138: AsyncQuery _asyncQuery = new AsyncQuery(); Line 2163: } Line 2164: else Line 2165: { Line 2166: if (model.getProgress() != null) Line 2167: { > this has already been checked Done Line 2168: return; Line 2169: } Line 2170: Line 2171: model.startProgress(null); Line 2182: params.setVirtioScsiEnabled(model.getIsVirtioScsiEnabled().getEntity()); Line 2183: setVmWatchdogToParams(model, params); Line 2184: setRngDeviceToParams(model, params); Line 2185: Line 2186: Frontend.getInstance().runAction(VdcActionType.AddVm, params, new UnitVmModelNetworkAsyncCallback(model, defaultNetworkCreatingManager), this); > the defaultNetworkCreatingManager does not launch the "guide" and you need Done Line 2187: } Line 2188: } Line 2189: Line 2190: protected static void buildVmOnSave(UnitVmModel model, VM vm) { -- To view, visit http://gerrit.ovirt.org/33142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd7f9cf4e6a9bcb2b336b34c785c09221068a915 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
