Jiří Moskovčák has posted comments on this change. Change subject: vdsm: use vdscli instead of vdsClient ......................................................................
Patch Set 1: (1 comment) Seems reasonable, please verify http://gerrit.ovirt.org/#/c/33996/1/src/ovirt_hosted_engine_setup/mixins.py File src/ovirt_hosted_engine_setup/mixins.py: Line 127: time.sleep(self.POWEROFF_CHECK_INTERVALL) Line 128: Line 129: self.logger.info(_('Creating VM')) Line 130: # TODO: check if we can move this to configurevm.py Line 131: # and get rid of the template. please either do what it says or make a bz ticket and remove the TODO from the code, otherwise it will be there forever... Line 132: conf = { Line 133: 'vmId': self.environment[ohostedcons.VMEnv.VM_UUID], Line 134: 'memSize': self.environment[ohostedcons.VMEnv.MEM_SIZE_MB], Line 135: 'display': self.environment[ohostedcons.VMEnv.CONSOLE_TYPE], -- To view, visit http://gerrit.ovirt.org/33996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f17abcc4ec83a69832bdb5a986136831504da2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
