Arik Hadas has posted comments on this change. Change subject: core: dont copy old num of sockets on hotplug ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34069/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java: Line 141: ( it looks wrong.. this one is always true: !isHotsetField(srcFld.getName()) || (isHotsetField(srcFld.getName()) so I think it should be: !isHotsetField(srcFld.getName()) || !hotsetEnabled right? -- To view, visit http://gerrit.ovirt.org/34069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
