Yair Zaslavsky has posted comments on this change. Change subject: aaa: remove duplicate groups from entities ......................................................................
Patch Set 1: (1 comment) ignore my comment, and see the linline one (about usage of HashSet/Set) http://gerrit.ovirt.org/#/c/34021/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java: Line 226: public void setGroupIds(Collection<Guid> groupIds) { Line 227: this.groupIds = new LinkedList(groupIds); Line 228: } Line 229: Line 230: public Collection<Guid> getGroupIds() { Oh, I thought you wrote you left it. I remember GWT has an issue with dynamic types but maybe it was solved in the current version. If this is the case, and it worked for you, no need to use LinkedList, use HashSet directly if you wish. Line 231: if (groupIds == null) { Line 232: groupIds = new LinkedList<Guid>(); Line 233: } Line 234: return groupIds; -- To view, visit http://gerrit.ovirt.org/34021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c1313c96e0e3e0900023efed2469dfea306632 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
