Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: fixing remote engine pki common code usage on upgrades ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/33786/6/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py: Line 106 Line 107 Line 108 Line 109 Line 110 these cases should be: cert_file=( oreportscons.FileLocations. OVIRT_ENGINE_PKI_REPORTS_APACHE_CERT ), otherwise very difficult to see what is kw and what is continuation. -- To view, visit http://gerrit.ovirt.org/33786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I011db10e16bb931c1610bc6645410917e722218d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
