Gilad Chaplik has posted comments on this change. Change subject: core, engine, userportal, webadmin: Fix balloon device presence in VM pools ......................................................................
Patch Set 1: Code-Review+1 (1 comment) +1 for frontend. http://gerrit.ovirt.org/#/c/33978/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java: Line 473: param.setRngDevice(model.getIsRngEnabled().getEntity() ? model.generateRngDevice() : null); Line 474: Line 475: param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 476: param.setBalloonEnabled(model.getMemoryBalloonDeviceEnabled().getEntity()); Line 477: odd that you need to set it in 2 places. but it doesn't make a such difference. Line 478: if (model.getQuota().getSelectedItem() != null) { Line 479: vm.setQuotaId(model.getQuota().getSelectedItem().getId()); Line 480: } Line 481: -- To view, visit http://gerrit.ovirt.org/33978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I379532f2a62ff16d8d11f34d62896125569197a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
