Idan Shaby has posted comments on this change. Change subject: core: Renamed the Method getStorageDomainByTypeAndPool ......................................................................
Patch Set 1: The motivation is this patch - http://gerrit.ovirt.org/#/c/34031/, where I added an overloaded method (getStorageDomain) to the class StorageDomainDAO. The new method takes another argument, status, so the alternative was to change the method's name from getStorageDomainByTypeAndPool to getStorageDomainByTypePoolAndStatus. Generally, I see no reason to give methods names such as: StorageDomain getStorageDomainByABC..AndZ (A a, B b, C c, ... , Z z) instead of just overloading it. If it makes a mess with the conventions, just say so and I'll change it. -- To view, visit http://gerrit.ovirt.org/34029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
