Alexander Wels has uploaded a new change for review.

Change subject: restapi,userportal,webadmin: secure cookie
......................................................................

restapi,userportal,webadmin: secure cookie

- Added secure cookie for session in webadmin,
  userportal, and rest api.

Change-Id: I4de909c25ec7b28d12dc7e325c366962c85d32a7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142728
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
M ovirt-engine.spec.in
4 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/33981/1

diff --git 
a/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 
b/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
index 2000d40..59608d2 100644
--- a/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
+++ b/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
@@ -128,6 +128,7 @@
     <session-timeout>180</session-timeout>
     <cookie-config>
       <http-only>true</http-only>
+      <secure>false</secure>
     </cookie-config>
   </session-config>
 
diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml 
b/frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
index e3903cd..b5c067d 100644
--- a/frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
+++ b/frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
@@ -162,6 +162,7 @@
     <session-config>
         <cookie-config>
             <http-only>true</http-only>
+            <secure>false</secure>
         </cookie-config>
     </session-config>
 
diff --git a/frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 
b/frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
index 9d22f7c..93836f9 100644
--- a/frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
+++ b/frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
@@ -169,6 +169,7 @@
     <session-config>
         <cookie-config>
             <http-only>true</http-only>
+            <secure>false</secure>
         </cookie-config>
     </session-config>
 
diff --git a/ovirt-engine.spec.in b/ovirt-engine.spec.in
index f0a6347..1755291 100644
--- a/ovirt-engine.spec.in
+++ b/ovirt-engine.spec.in
@@ -596,6 +596,9 @@
        sed -i \
                
's#<transport-guarantee>NONE</transport-guarantee>#<transport-guarantee>CONFIDENTIAL</transport-guarantee>#'
 \
                "${war}/WEB-INF/web.xml"
+        sed -i \
+                's#<secure>false</secure>#<secure>true</secure>#' \
+                "${war}/WEB-INF/web.xml"
 done
 
 #


-- 
To view, visit http://gerrit.ovirt.org/33981
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4de909c25ec7b28d12dc7e325c366962c85d32a7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to