Martin Mucha has posted comments on this change. Change subject: core: AuditLogType.UNASSIGNED should not be logged ......................................................................
Patch Set 3: sure, it can. But I don't think it's going to be small change. Root of this is one bad decision, that if we do not want do log something, we assing AuditLogType to UNASSIGNED, and it was realized via insane decision to block logging with missing translation of UNASSIGNED. So this patch only removes insanity from code, which was easy. There are lot of methods returning AuditLogType, level of message to be logged, which one value has special meaning ~ disabling logging. It's doable to split AuditLogType value into two informations: "shouldLog" and "logLevel", but it would be rather big change, and I think this wound does not bleed that bad so it has to be stitched. -- To view, visit http://gerrit.ovirt.org/33359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97bf90264d1a1b3d8ea571daa9346d1f6b6d18d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
