Martin Mucha has posted comments on this change. Change subject: webadmin: syntax sugar, simplified popup definition syntax ......................................................................
Patch Set 2: in NetworkModule.java there are two ways how to create a SearchableDetailModelProvider or SearchableModelProvider compared to previously used solution. I think SearchableModelProvider can be used everywhere, also in places where SearchableDetailModelProvider is currently used. Aside from code duplication removal, less error prone syntax moving to this implementation removes lot of anonymous classes creation. Also notice, that this can be applied in broader context than you required. -- To view, visit http://gerrit.ovirt.org/33942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d2a31583b16a70fb4763a0915a2641ebda9e1e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
