Martin Betak has posted comments on this change. Change subject: core, frontend: Query to get raw provider certificates ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Minor formatting comment. Otherwise looks good. http://gerrit.ovirt.org/#/c/33961/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainTextQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainTextQuery.java: Line 26: Line 27: private String chainToString(List<? extends Certificate> chain) { Line 28: StringBuilder certStringBuilder = new StringBuilder(); Line 29: if (chain != null) { Line 30: for( Certificate certificate : chain ) { Probably the order of parenthesis and space should be switched. Line 31: certStringBuilder.append(certificate.toString()); Line 32: certStringBuilder.append('\n'); Line 33: } Line 34: } -- To view, visit http://gerrit.ovirt.org/33961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5270bff9b671943fdea1c31369b7ad1d0dd4f67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
