Lior Vernia has posted comments on this change. Change subject: webadmin: removed ugly if-else chain ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/33619/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3223: public Guid getEntityGuid(Object entity) { Line 3224: if (entity instanceof BusinessEntity) { Line 3225: //BusinessEntity can have lot of different ID types, but from this context it cannot be determined. Line 3226: //cast is present JUST to point to proper method, it's not able to guarantee return type of that method. Line 3227: Object id = getEntityGuid((BusinessEntity<? extends Guid>) entity); > I wrote you mail about it. It is rather confusing, but for some reason, wh Please read again what I wrote in the previous patchset and in the comment just above. Why not replace the call to getEntityGuid((BusinessEntity<? extends Guid>) entity) with ((BusinessEntity<?>) entity).getId()? Line 3228: Line 3229: //check whether result can be casted to Guid, otherwise continue with explicit rules. Line 3230: if (id instanceof Guid) { Line 3231: return (Guid) id; -- To view, visit http://gerrit.ovirt.org/33619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic716dc67b90c1d575de14c40b504c984bf0467f2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
