Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds helpers to configure java logging in tools ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/32852/8/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java: Line 40: public static void addFileHandler(String fileName) { Line 41: try { Line 42: FileHandler fh = new FileHandler(fileName); Line 43: fh.setFormatter(new SimpleFormatter()); Line 44: OVIRT_LOGGER.addHandler(fh); > If i add handler to root logger, then it will contain also log messages fro yes, this is the entire idea of log file :) Line 45: } catch (SecurityException | IOException ex) { Line 46: throw new IllegalArgumentException( Line 47: String.format("Error accessing log file '%s': '%s'", fileName, ex.getMessage()), Line 48: ex); -- To view, visit http://gerrit.ovirt.org/32852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c46ca552888b347a4ff810003e0fcc818f832f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
