Moti Asayag has posted comments on this change.

Change subject: core: Prevent migrating paused VM
......................................................................


Patch Set 4:

It prevents a programmer from customizing the returned value for the enum name:

VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND.name() - will always return 
"ACTION_TYPE_FAILED_VM_NOT_FOUND"

however VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND.toString() may return 
other value, depends whether toString() was overridden by 
ACTION_TYPE_FAILED_VM_NOT_FOUND.

--
To view, visit http://gerrit.ovirt.org/6660
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13179ca22f3e00fc73ad91fd6ade1cab83b82d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to