Alon Bar-Lev has posted comments on this change. Change subject: tools: Replace log4j with slf4j as frontend in notifier ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/33773/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java: Line 168: log.info("Send email to [{}]\n subject:\n [{}]", Line 169: attempt.address, Line 170: message.getMessageSubject()); Line 171: if (log.isDebugEnabled()) { Line 172: log.debug("body:\n [{}]", I think that we should add multiple logs instead of newline within. Line 173: message.getMessageBody()); Line 174: } Line 175: sendMail(attempt.address, message.getMessageSubject(), message.getMessageBody()); Line 176: notifyObservers(DispatchResult.success(attempt.event, attempt.address, EventNotificationMethod.SMTP)); -- To view, visit http://gerrit.ovirt.org/33773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc192c7f10d7f9a124d2899118f6c5c7126b7230 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
