mooli tayer has posted comments on this change. Change subject: core: don't check for null serverity, forbid it. ......................................................................
Patch Set 6: (1 comment) nit http://gerrit.ovirt.org/#/c/30041/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 1111: private AuditLogType(int value, int eventFloodRate) { Line 1112: this(value, AuditLogSeverity.NORMAL, eventFloodRate); Line 1113: } Line 1114: Line 1115: private AuditLogType(int value, AuditLogSeverity severity, int eventFloodRate) { Some one can call this directly, no? always pass the nullable value and do it here. I would also always pass null in all this() calls here, so that default is only defined once - not that important. Line 1116: intValue = value; Line 1117: this.eventFloodRate = eventFloodRate; Line 1118: this.severity = severity; Line 1119: } -- To view, visit http://gerrit.ovirt.org/30041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic44fb1683bacfa1c0f992ad4f272c3bb56526836 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
