Omer Frenkel has posted comments on this change.

Change subject: core: Cluster parameters override - scheduler \ actions \ 
queries
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

sla ping

http://gerrit.ovirt.org/#/c/32548/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java:

Line 681: 
Line 682:         VmHandler.updateVmGuestAgentVersion(getVm());
Line 683: 
Line 684:         // update dynamic cluster-parameters
Line 685:         if(getVm().getCpuName() == null) { // no run-once data -> use 
static field or inherit from cluster
still need to run the formatter
Line 686:             if (getVm().getCustomCpuName() != null) {
Line 687:                 getVm().setCpuName(getVm().getCustomCpuName());
Line 688:             } else {
Line 689:                 // get what cpu flags should be passed to vdsm 
according to the cluster


-- 
To view, visit http://gerrit.ovirt.org/32548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshac...@redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to