Frank Kobzik has posted comments on this change. Change subject: core: add graphics device to management classes ......................................................................
Patch Set 20: (2 comments) http://gerrit.ovirt.org/#/c/28567/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 525: return false; Line 526: } Line 527: Line 528: // Check if the display type is supported Line 529: // todo os info follow up > what is missing? Rewriting the isDisplayTypeSupported method (so that it works with both display[QXL vs VGA,CIRRUS] & graphics[SPICE vs VNC]). But it's in OS info patch. Line 530: if (!VmHandler.isDisplayTypeSupported(getParameters().getVmStaticData().getOsId(), Line 531: vmFromParams.getDefaultDisplayType(), Line 532: getReturnValue().getCanDoActionMessages(), Line 533: getVdsGroup().getcompatibility_version())) { http://gerrit.ovirt.org/#/c/28567/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 787: protected boolean hasWatchdog() { Line 788: return getParameters().getWatchdog() != null; Line 789: } Line 790: Line 791: protected boolean checkNumberOfMonitors() { // todo rewrite this ugly method > so you will re-write? I put comments in code to clarify the method. In the end I don't think it's so complex. Line 792: Set<GraphicsType> currentVmGraphics = new HashSet<>(); Line 793: Set<GraphicsType> graphicsTypesToBeModified = getParameters().graphicsTypesToBeSet(); Line 794: int numOfMonitors = getParameters().getVmStaticData().getNumOfMonitors(); Line 795: -- To view, visit http://gerrit.ovirt.org/28567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c84ce94cd3cb52286c52d765a389e69c9b0e62 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
