Alexander Wels has posted comments on this change. Change subject: webadmin: Host SSH Fingerprint success message shouldn't be in red text ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33729/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java: Line 697: @Override Line 698: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 699: String fetchResultText = object.getFetchResult().getEntity(); Line 700: if (ConstantsManager.getInstance().getConstants().errorLoadingFingerprint().equals(fetchResultText)) { Line 701: fetchResult.setStyleName(style.fetchResultErrorLabel()); This should be: fetchResult.addStyleName(style.fetchResultErrorLabel()); Otherwise the original style will be lost when you go from good state -> error state -> good state. Going to the error state will wipe out the original style. Line 702: } else { Line 703: fetchResult.removeStyleName(style.fetchResultErrorLabel()); Line 704: } Line 705: fetchResult.setText(fetchResultText); -- To view, visit http://gerrit.ovirt.org/33729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
