Yair Zaslavsky has posted comments on this change.

Change subject: cleanup: bootstrap interface methods name compliance
......................................................................


Patch Set 2: (2 inline comments)

Minor comments.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CBCInstaller.java
Line 58:             _wrapper.execute(createCertReqCommand);
+1 On Juan's comment.

....................................................
File 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/IPWorksInstallWrapperTest.java
Line 14:      * public void testLoginToHattrick() { IPWorksInstallWrapper 
wrapper = new IPWorksInstallWrapper() ;
Not sure why we have these comments.
Let's remove them instead of fixing their content.

--
To view, visit http://gerrit.ovirt.org/6723
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea5ff946cb70c4836b6364a695ed8ce7911a8b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to