Frank Kobzik has posted comments on this change. Change subject: core: OsInfo-related changes ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/30838/20/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java: Line 331: Line 332: return graphicsAndDisplays; Line 333: } Line 334: Line 335: private Pair<String, String> parseGraphicsAndDisplayPair(String displayAndGraphicsString) { > whats the difference between this and parseDisplayProtocol ? Oops! looks like I accidentally duplicated it. Thanks for this catch. Line 336: String[] displayAndGraphicsSplit = displayAndGraphicsString.split("/"); Line 337: if (displayAndGraphicsSplit.length == 2) { Line 338: return new Pair<>(displayAndGraphicsSplit[0].trim(), Line 339: displayAndGraphicsSplit[1].trim()); -- To view, visit http://gerrit.ovirt.org/30838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c7126308ab4e5e5418d804a8550a50e9994894 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
