Frank Kobzik has posted comments on this change. Change subject: engine: Change DisplayType semantics ......................................................................
Patch Set 19: (2 comments) Thanks for comments! http://gerrit.ovirt.org/#/c/30837/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java: Line 139: createVmParams.setSysPrepParams(sysPrepParams); Line 140: Line 141: createVmParams.getVm().setVmInit(getParameters().getVmInit()); Line 142: Line 143: for (GraphicsType graphicsType : getParameters().getRunOnceGraphics()) { > what if i do run-once and dont want to change the graphics? (for example us ...then the VM is started with graphics that are defined in the vm_device table (see VmInfoBuilder). Line 144: getVm().getGraphicsInfos().put(graphicsType, new GraphicsInfo()); Line 145: } Line 146: Line 147: return createVmParams; Line 140: Line 141: createVmParams.getVm().setVmInit(getParameters().getVmInit()); Line 142: Line 143: for (GraphicsType graphicsType : getParameters().getRunOnceGraphics()) { Line 144: getVm().getGraphicsInfos().put(graphicsType, new GraphicsInfo()); > this will be in addition to what loaded from db? nope. I think my previous comment explains - If graphicsInfos is non-empty, it's used for creating graphics, otherwise engine will use vm_device table. Line 145: } Line 146: Line 147: return createVmParams; Line 148: } -- To view, visit http://gerrit.ovirt.org/30837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0907c9086f49f909250d9956356a0251954f1427 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
