Frank Kobzik has posted comments on this change. Change subject: core: GraphicsInfo db persistence part ......................................................................
Patch Set 21: (2 comments) http://gerrit.ovirt.org/#/c/28570/21/packaging/dbscripts/upgrade/03_06_0140_add_graphics_info_columns.sql File packaging/dbscripts/upgrade/03_06_0140_add_graphics_info_columns.sql: Line 29: '', Line 30: true, Line 31: true, Line 32: false, Line 33: 'now', > not sure this set the time of now according to [1] it works. Also, I tested it :) [1]: http://www.postgresql.org/docs/8.2/static/functions-datetime.html#FUNCTIONS-DATETIME-CURRENT Line 34: NULL, Line 35: NULL Line 36: FROM vm_static Line 37: WHERE default_display_type = 0 and not exists Line 88: -- todo should be rewritten Line 89: create or replace function adjust_spice_port() returns void Line 90: as $function$ Line 91: begin Line 92: if (exists (select 1 from information_schema.columns where table_name ilike 'vm_dynamic' and column_name ilike 'display')) then > no need to work hard, the upgrade scripts should be executed only once on a That's weird - it contradicts with packaging/dbscripts/README file (which says the scripts must be reentrant...). But after discussing with Tomas I believe you're right. So maybe we need README file upgrade. Line 93: update vm_dynamic set spice_port = display where display_type = 0; Line 94: end if; Line 95: end; $function$ Line 96: language plpgsql; -- To view, visit http://gerrit.ovirt.org/28570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a129454fc64aa34493b0495fb76f22f3d667e14 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
