Tomas Jelinek has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/33770/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java: Line 107: return vncNative; Line 108: } Line 109: Line 110: private void attachRestApiSessionIdHandler(final RestApiSessionIdAware pluginImpl) { Line 111: eventBus.addHandler(RestApiSessionAcquiredEvent.getType(), new RestApiSessionAcquiredEvent.RestApiSessionAcquiredHandler() { Is this guaranteed to happen soon enough? Because if this happens after the session is acquired, it will never get the session. Line 112: @Override Line 113: public void onRestApiSessionAcquired(RestApiSessionAcquiredEvent event) { Line 114: pluginImpl.setRestApiSessionId(event.getSessionId()); Line 115: } http://gerrit.ovirt.org/#/c/33770/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java: Line 67: private SpiceMenu menu; Line 68: Line 69: private ISpice privatespice; Line 70: private ClientConsoleMode consoleMode; Line 71: private String restApiSessionId; I guess you can delete this Line 72: Line 73: private void setspice(ISpice value) { Line 74: privatespice = value; Line 75: } Line 408: .getConstants() Line 409: .usbDevicesNoUsbdevicesClientSpiceUsbRedirectorNotInstalled() }); Line 410: Line 411: if (restApiSessionId != null) { Line 412: I guess you can delete this Line 413: } Line 414: Line 415: // Create menu. Line 416: int id = 1; -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
