Martin Peřina has posted comments on this change. Change subject: packaging: Adapt to splitted modules directories ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/32846/5/Makefile File Makefile: Line 354: # won't get artifacts of older branches Line 355: # we should use search MAVEN_OUTPUT_DIR as it may contain Line 356: # pre-compiled artifacts at different hierarchy. Line 357: install -dm 0755 "$(DESTDIR)$(PKG_JBOSS_MODULES)" Line 358: for category in common tools; do \ > I almost sure you are ahead in this tools thing, even common? Common is needed here, because previous patch marks all existing modules with common category by default. There's is no modules in tools category yet, but I described two existing categories in doc of previous patch, so it seemed logical to have it here also. Line 359: install -dm 0755 "$(DESTDIR)$(PKG_JBOSS_MODULES)/$${category}"; \ Line 360: find "$(MAVEN_OUTPUT_DIR)" -name '*'"-$${category}-modules.zip" | grep -v tmp.repos | xargs -r -n 1 unzip -q -o -d "$(DESTDIR)$(PKG_JBOSS_MODULES)/$${category}"; \ Line 361: done Line 362: install -dm 0755 "$(DESTDIR)$(PKG_EAR_DIR)" http://gerrit.ovirt.org/#/c/32846/5/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 27 Line 28 Line 29 Line 30 Line 31 > please leave this comment Done -- To view, visit http://gerrit.ovirt.org/32846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
