Alon Bar-Lev has posted comments on this change. Change subject: tools: Replaces log4j with JUL as backend for engine-config ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33757/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java: Line 13: parser = new EngineConfigCLIParser(); Line 14: parser.parse(args); Line 15: Line 16: EngineConfigMap argsMap = parser.getEngineConfigMap(); Line 17: if (argsMap.getLogFile() != null) { same... two separate parameters, one for file and one for level, these should be detached. Line 18: JavaLoggingUtils.addFileHandler(argsMap.getLogFile(), argsMap.getLogLevel()); Line 19: } Line 20: } catch (Throwable t) { Line 21: System.out.println(t.getMessage()); http://gerrit.ovirt.org/#/c/33757/2/packaging/bin/engine-config.sh File packaging/bin/engine-config.sh: Line 109: # not possible to debug the execution of the main method. Line 110: # Line 111: Line 112: exec "${JAVA_HOME}/bin/java" \ Line 113: -Xbootclasspath/p:${ENGINE_USR}/modules/common/org/ovirt/engine/core/utils/main/utils.jar \ same, I am unsure we need bootclasspath, but if we do we need to handle this differently. Line 114: -Djava.util.logging.config.file=${OVIRT_LOGGING_PROPERTIES} \ Line 115: -Djboss.modules.write-indexes=false \ Line 116: -jar "${JBOSS_HOME}/jboss-modules.jar" \ Line 117: -dependencies org.ovirt.engine.core.tools \ -- To view, visit http://gerrit.ovirt.org/33757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b340115f68cf88b6ebd3166044f974fed9e798b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
