Alon Bar-Lev has posted comments on this change. Change subject: tools: Replaces log4j with JUL as backend for manage-domains ......................................................................
Patch Set 6: (3 comments) don't we need something for notifier? http://gerrit.ovirt.org/#/c/32853/6/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java: Line 16: mdArgs = new ManageDomainsArguments(); Line 17: mdArgs.parse(args); Line 18: Line 19: if (mdArgs.contains(ARG_LOG_FILE)) { Line 20: JavaLoggingUtils.addFileHandler(mdArgs.get(ARG_LOG_FILE), mdArgs.get(ARG_LOG_LEVEL)); don't we have two separate arguments for log file and log level? why do we create relationship between them? Line 21: } Line 22: } catch (Throwable t) { Line 23: System.out.println(t.getMessage()); Line 24: System.exit(1); http://gerrit.ovirt.org/#/c/32853/6/packaging/bin/engine-manage-domains.sh File packaging/bin/engine-manage-domains.sh: Line 18: # not possible to debug the execution of the main method. Line 19: # Line 20: Line 21: exec "${JAVA_HOME}/bin/java" \ Line 22: -Xbootclasspath/p:${ENGINE_USR}/modules/common/org/ovirt/engine/core/utils/main/utils.jar \ oh, no! do we must have this? what is the reason? if we must have it, we should create a jar with only what is required to be injected into bootclasspath. also never use prepend if you do not mean to do so, and this I am sure we should not do. Line 23: -Djava.util.logging.config.file=${OVIRT_LOGGING_PROPERTIES} \ Line 24: -Djboss.modules.write-indexes=false \ Line 25: -jar "${JBOSS_HOME}/jboss-modules.jar" \ Line 26: -dependencies org.ovirt.engine.extensions.builtin \ Line 19: # Line 20: Line 21: exec "${JAVA_HOME}/bin/java" \ Line 22: -Xbootclasspath/p:${ENGINE_USR}/modules/common/org/ovirt/engine/core/utils/main/utils.jar \ Line 23: -Djava.util.logging.config.file=${OVIRT_LOGGING_PROPERTIES} \ quotes please Line 24: -Djboss.modules.write-indexes=false \ Line 25: -jar "${JBOSS_HOME}/jboss-modules.jar" \ Line 26: -dependencies org.ovirt.engine.extensions.builtin \ Line 27: -class org.ovirt.engine.extensions.aaa.builtin.tools.ManageDomainsExecutor \ -- To view, visit http://gerrit.ovirt.org/32853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16afc336c26615978392f7d4ff911bf646c42df6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
