Daniel Erez has posted comments on this change. Change subject: core: Fix NPE when VM does not exists on register ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/33868/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 146: } Line 147: Line 148: @Override Line 149: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 150: if ((getParameters().getVm() != null) && (!StringUtils.isBlank(getParameters().getVm().getName()))) { nit: i think the extra parenthesis in the inner clauses are redundant (just a matter of taste...) Line 151: return Collections.singletonMap(getParameters().getVm().getName(), Line 152: LockMessagesMatchUtil.makeLockingPair(LockingGroup.VM_NAME, Line 153: VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED)); Line 154: } Line 148: @Override Line 149: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 150: if ((getParameters().getVm() != null) && (!StringUtils.isBlank(getParameters().getVm().getName()))) { Line 151: return Collections.singletonMap(getParameters().getVm().getName(), Line 152: LockMessagesMatchUtil.makeLockingPair(LockingGroup.VM_NAME, nit2: irrelevant formatting... Line 153: VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED)); Line 154: } Line 155: return null; Line 156: } -- To view, visit http://gerrit.ovirt.org/33868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb846cc16d1d208f0b96a127169f717a3fec89e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
