Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: messages locale unit test ......................................................................
Patch Set 2: (1 comment) Alex, please see my inline comment regarding checkstyle POM change. http://gerrit.ovirt.org/#/c/32995/2/frontend/webadmin/modules/pom.xml File frontend/webadmin/modules/pom.xml: Line 199: </sources> Line 200: </configuration> Line 201: </plugin> Line 202: <plugin> Line 203: <artifactId>maven-checkstyle-plugin</artifactId> > this is basically done to exclude test classes from checkstyle as it barfs > this is basically done to exclude test classes from checkstyle I'll ask about this on devel list, might be relevant for Engine backend, too. Hm, root POM already contains maven-checkstyle-plugin definition in <pluginManagement> with stuff like <dependencies> and default <configuration>, the only problem is that the <execution> doesn't have ID assigned, so you cannot customize that execution directly. I propose to add execution ID to maven-checkstyle-plugin definition in root POM, and in this POM just customize that execution (without duplicating whole plugin definition), like so: <plugin> <artifactId>maven-checkstyle-plugin</artifactId> <executions> <execution> <id>checkstyle</id> <configuration> <includeTestSourceDirectory>false</includeTestSourceDirectory> </configuration> </execution> </executions> <plugin> See my other patch http://gerrit.ovirt.org/#/c/33707/ for reference. Line 204: <dependencies> Line 205: <dependency> Line 206: <groupId>org.ovirt.engine</groupId> Line 207: <artifactId>checkstyles</artifactId> -- To view, visit http://gerrit.ovirt.org/32995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
