Eldan Shachar has posted comments on this change.

Change subject: restapi: Cluster parameters override
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/31581/5/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd:

Line 489:   </xs:complexType>
Line 490: 
Line 491:   <xs:element name="custom_emulated_machine" type="xs:string"/>
Line 492: 
Line 493:   <xs:element name="custom_cpu_model" type="xs:string"/>
> These ^ two elements aren't needed. We only need this kind of top level ele
Done
Line 494: 
Line 495:   <xs:complexType name="TemplateVersion">
Line 496:     <xs:sequence>
Line 497:        <xs:element name="base_template" type="Template"  
minOccurs="0" maxOccurs="1"/>


Line 3076:           <xs:element ref="serial_number" minOccurs="0" 
maxOccurs="1" />
Line 3077:           <xs:element name="start_paused" type="xs:boolean" 
minOccurs="0" maxOccurs="1" />
Line 3078:           <xs:element ref="cpu_profile" minOccurs="0" maxOccurs="1"/>
Line 3079:           <xs:element ref="custom_emulated_machine" minOccurs="0" 
maxOccurs="1"/>
Line 3080:           <xs:element ref="custom_cpu_model" minOccurs="0" 
maxOccurs="1"/>
> Use: name="custom_cpu_model" type="xs:string".
Done
Line 3081:         </xs:sequence>
Line 3082:       </xs:extension>
Line 3083:     </xs:complexContent>
Line 3084:   </xs:complexType>


-- 
To view, visit http://gerrit.ovirt.org/31581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe64e713edd43cad33b385699159db534112c02
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshac...@redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to